fix(sentinel-one): set failure only from an explicit final status (rebase of #2679) - #2753
Merged
Merged
Conversation
Rebase of #2679 onto current v11 (post #2677, sentinel-one 3.0.1 -> 3.2.0). Consolidates the 3-step 'failed' actionResult block into one guarded single-step verdict: failure only on exact/anchored mitigation_failed / failed, case-insensitive, with a negative guard so contradictory or successful statuses stay unknown. Adds the action-result contract test and fixture (10 cases) which passes against go-sdk v1.1.36.
❌ Go dependencies check failedThere are outdated Go dependencies, or modules that could not be inspected. Script output |
🛑 AI review — Blocking issuesOne or more high/critical issues can break things and must be fixed before merging. Details below. ✅
|
![utmstackprapprover[bot]](https://avatars.githubusercontent.com/u/144401876?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #2679 onto current v11 (post #2677; sentinel-one filter 3.0.1 -> 3.2.0). #2679's original fork branch now conflicts with the merged #2677 on the version line and CEF extraction; this applies its actual change (the consolidated single-step ailure verdict replacing the 3-step ailed block) on top of current v11, plus its action-result contract test + fixture (10 cases, passing against go-sdk v1.1.36). No rule consumes sentinel-one �ctionResult, so the ailed-> ailure swap is safe. Closes #2679.